Improve promotion code batch #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, when the Spree::PromotionCode creation failed, the exception was raised and the job fails with error. This commit rescues the creation exception and remove the failed code from the codes list.
Collecting results of large code counts can exceed available memory. This was initially proposed on another PR that we are basing this one on: solidusio#5383 Co-authored-by: Jared Norman <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: Benjamin <[email protected]> Co-authored-by: Sofia <[email protected]> Co-authored-by: Senem Soy <[email protected]> Co-authored-by: Andrew Stewart <[email protected]> Co-authored-by: Chris <[email protected]>
github-actions
bot
added
the
changelog:repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5830 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 737 737
Lines 17188 17189 +1
=======================================
+ Hits 15304 15305 +1
Misses 1884 1884 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Aug 16, 2024
kennyadsl
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are opening a PR with the work from #5383. This fixes #5379.
We integrated suggestions from the reviewers on #5383.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: